Skip to content

[CI] Fix portbiding tests#2987

Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom
shiftstack:port-binding-policies
Mar 11, 2024
Merged

[CI] Fix portbiding tests#2987
pierreprinetti merged 1 commit intogophercloud:masterfrom
shiftstack:port-binding-policies

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Mar 10, 2024

Since https://review.opendev.org/c/openstack/neutron/+/909075, port-binding operation are restricted to the service role.

Update the policies so that we can continue exercising these tests in CI.

Fixes #2983

Since https://review.opendev.org/c/openstack/neutron/+/909075,
port-binding operation are restricted to the service role.

Update the policies so that we can continue exercising these tests in
CI.

Fixes gophercloud#2983
@mandre
Copy link
Copy Markdown
Contributor Author

mandre commented Mar 10, 2024

Totally untested, let's see if this makes the CI happy.

@github-actions github-actions bot added the semver:patch No API change label Mar 10, 2024
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 77.275%. remained the same
when pulling a2f421e on shiftstack:port-binding-policies
into b74d3b1 on gophercloud:master.

@mandre
Copy link
Copy Markdown
Contributor Author

mandre commented Mar 10, 2024

CI is indeed happy 🎉

@mandre mandre added the backport-v1 This PR will be backported to v1 label Mar 10, 2024
@pierreprinetti pierreprinetti merged commit c7d7c33 into gophercloud:master Mar 11, 2024
@pierreprinetti pierreprinetti deleted the port-binding-policies branch March 11, 2024 09:41
@mandre
Copy link
Copy Markdown
Contributor Author

mandre commented Mar 11, 2024

CI is indeed happy 🎉

Did I look at the wrong job output? This patch didn't fix the fwaas jobs, they now fail for a different reason as seen in https://github.com/gophercloud/gophercloud/actions/runs/8230725850/job/22504571160?pr=2982

@mandre
Copy link
Copy Markdown
Contributor Author

mandre commented Mar 11, 2024

I even changed the wrong file 🤦
What's going on there?!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v1 This PR will be backported to v1 semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Networking job is currently failing

3 participants