Skip to content

authentication: Add WithContext functions#2890

Merged
EmilienM merged 2 commits intogophercloud:masterfrom
shiftstack:tokens_withcontext
Feb 5, 2024
Merged

authentication: Add WithContext functions#2890
EmilienM merged 2 commits intogophercloud:masterfrom
shiftstack:tokens_withcontext

Conversation

@pierreprinetti
Copy link
Copy Markdown
Member

@pierreprinetti pierreprinetti commented Feb 2, 2024

Allow using a context to cancel and trace authentication calls.

In the process, add WithContext functions to token-requesting packages:

  • openstack/identity/v2/tokens/requests.go
  • openstack/identity/v3/extensions/ec2tokens/requests.go
  • openstack/identity/v3/extensions/oauth1/requests.go
  • openstack/identity/v3/tokens/requests.go

@github-actions github-actions bot added the semver:minor Backwards-compatible change label Feb 2, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 2, 2024

Coverage Status

coverage: 77.874% (+0.01%) from 77.863%
when pulling c9b54ab on shiftstack:tokens_withcontext
into 901515a on gophercloud:master.

@github-actions github-actions bot removed the semver:minor Backwards-compatible change label Feb 2, 2024
@pierreprinetti pierreprinetti changed the title tokens: Add WithContext functions authentication: Add WithContext functions Feb 2, 2024
@github-actions github-actions bot added the semver:minor Backwards-compatible change label Feb 2, 2024
Allow using a context to cancel and trace authentication calls.
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Feb 2, 2024
@pierreprinetti pierreprinetti added the backport-v1 This PR will be backported to v1 label Feb 2, 2024
@EmilienM EmilienM merged commit 09daf4a into gophercloud:master Feb 5, 2024
@EmilienM EmilienM deleted the tokens_withcontext branch February 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v1 This PR will be backported to v1 semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants