pager: Add WithContext functions#2889
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Feb 5, 2024
Merged
Conversation
to enable dependant packages to build ListWithContext.
pierreprinetti
commented
Feb 2, 2024
| // EachPageWithContext iterates over each page returned by a Pager, yielding | ||
| // one at a time to a handler function. Return "false" from the handler to | ||
| // prematurely stop iterating. | ||
| func (p Pager) EachPageWithContext(ctx context.Context, handler func(context.Context, Page) (bool, error)) error { |
Member
Author
There was a problem hiding this comment.
note for the reviewer.
This could be:
func (p Pager) EachPageWithContext(ctx context.Context, handler func(Page) (bool, error)) error {... if we want the caller to embed an external context with a closure instead.
However, since we’re at it, I think it makes sense to go the full Context experience.
EmilienM
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to enable dependant packages to build ListWithContext.