Skip to content

[db/v1/instance]: adding support for availability_zone for a db instance#2871

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
zhekazuev:feature/add-openstack-db-instance-az
Jan 19, 2024
Merged

[db/v1/instance]: adding support for availability_zone for a db instance#2871
EmilienM merged 1 commit intogophercloud:masterfrom
zhekazuev:feature/add-openstack-db-instance-az

Conversation

@zhekazuev
Copy link
Copy Markdown
Contributor

@zhekazuev zhekazuev commented Jan 18, 2024 •
edited
Loading

Issue

For #2874

Description

  • code: added AvailabilityZone struct field
  • code: add empty checking for that field
  • tests: add availability_zone to testing/fixtures_test.go
  • tests: add AvailabilityZone to testing/requests_test.go

Links

Related:

@github-actions github-actions bot added the semver:minor Backwards-compatible change label Jan 18, 2024
github-actions[bot]
github-actions bot reviewed Jan 18, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

This was referenced Jan 18, 2024
Merged
Open
@zhekazuev zhekazuev changed the title [v1] db/v1/instance: add AvailabilityZone field [wip][v1] db/v1/instance: add AvailabilityZone field Jan 19, 2024
@zhekazuev zhekazuev changed the title [wip][v1] db/v1/instance: add AvailabilityZone field [wip][v1] db/v1/instance: adding support for availability_zone for a db instance Jan 19, 2024
@zhekazuev zhekazuev marked this pull request as ready for review January 19, 2024 10:38
@zhekazuev zhekazuev changed the title [wip][v1] db/v1/instance: adding support for availability_zone for a db instance [v1] db/v1/instance: adding support for availability_zone for a db instance Jan 19, 2024
@zhekazuev zhekazuev changed the title [v1] db/v1/instance: adding support for availability_zone for a db instance [db/v1/instance]: adding support for availability_zone for a db instance Jan 19, 2024
@zhekazuev
Copy link
Copy Markdown
Contributor Author

zhekazuev commented Jan 19, 2024

@EmilienM Hi,

Could you review it?

@zhekazuev
Copy link
Copy Markdown
Contributor Author

zhekazuev commented Jan 19, 2024 •
edited
Loading

Tests result:

@zhekazuev ➜ .../openstack/db/v1/instances (feature/add-openstack-db-instance-az) $ go test -tags fixtures ./...
?       github.com/gophercloud/gophercloud/openstack/db/v1/instances    [no test files]
ok      github.com/gophercloud/gophercloud/openstack/db/v1/instances/testing    (cached)

EmilienM
EmilienM previously approved these changes Jan 19, 2024
View reviewed changes
EmilienM
EmilienM reviewed Jan 19, 2024
View reviewed changes
EmilienM
EmilienM reviewed Jan 19, 2024
View reviewed changes
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Jan 19, 2024
@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Jan 19, 2024

ideal you would squash commits here

@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Jan 19, 2024
@zhekazuev
feat: add AvailabilityZone for db/v1/instance
74052e2 
fix: alignments

fix: alignments

added: AvailabilityZone for db/v1/instance
@zhekazuev zhekazuev force-pushed the feature/add-openstack-db-instance-az branch from 9de4ebf to 74052e2 Compare January 19, 2024 15:23
@github-actions github-actions bot removed the semver:minor Backwards-compatible change label Jan 19, 2024
@zhekazuev
Copy link
Copy Markdown
Contributor Author

zhekazuev commented Jan 19, 2024

Squashing well done.

@github-actions github-actions bot added the semver:minor Backwards-compatible change label Jan 19, 2024
EmilienM
EmilienM approved these changes Jan 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution and welcome here!

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2024

Coverage Status

coverage: 77.835% (+0.003%) from 77.832%
when pulling 74052e2 on zhekazuev:feature/add-openstack-db-instance-az
into d0c1d7e on gophercloud:master.

@EmilienM EmilienM merged commit 8587253 into gophercloud:master Jan 19, 2024
@zhekazuev
Copy link
Copy Markdown
Contributor Author

zhekazuev commented Jan 19, 2024

@EmilienM Short question about releasing,

That changes needs for different project, terraform-provider-openstack, so is it possible to release new version of that sdk?
E.g. 1.8.1?

Or how can I reuse that package by commit?
When I tried to do go get ...@<commit> I recieved 1.5.1-... version, expected 1.8.0-....

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Jan 19, 2024

If you want this patch in v1, you need to add the laberl backport-v1 label in this PR and the backport PR will be automatically created and reviewed by us.
If you don't want v1, you'll need to wait for a v2 (@pierreprinetti is leading this effort at the moment, I'm unsure about its exact status).

@zhekazuev zhekazuev deleted the feature/add-openstack-db-instance-az branch January 19, 2024 17:49
@zhekazuev
Copy link
Copy Markdown
Contributor Author

zhekazuev commented Jan 19, 2024 •
edited
Loading

If you want this patch in v1, you need to add the laberl backport-v1 label in this PR and the backport PR will be automatically created and reviewed by us.

@EmilienM,
I cannot add label backport-v1 to the PR, maybe to low permissions level.
Could you do that?

@EmilienM EmilienM added the backport-v1 This PR will be backported to v1 label Jan 19, 2024
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Jan 19, 2024
Merged
This was referenced Jan 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@EmilienM EmilienM EmilienM approved these changes

Assignees

No one assigned

Labels

backport-v1 This PR will be backported to v1 semver:minor Backwards-compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhekazuev @EmilienM @coveralls