unit tests: Fix the installation of tools#2840
Merged
EmilienM merged 1 commit intogophercloud:v1from Nov 30, 2023
Merged
Conversation
mandre
reviewed
Nov 30, 2023
Install Go tools with new newest Go version before switching to the target version of Go to run the unit tests. This commit fixes an issue where the Go tools we use in unit tests can't be compiled with Go v1.14 any more.
78800fd to
ccfa81e
Compare
EmilienM
approved these changes
Nov 30, 2023
Contributor
|
Unit tests have passed we don't have to wait for the functional tests to pass, this is good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install Go tools with new newest Go version before switching to the target version of Go to run the unit tests.
This commit fixes an issue where the Go tools we use in unit tests can't be compiled with Go v1.14 any more.