Add more godoc to GuestFormat#2822
Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom Oct 24, 2023
Merged
Conversation
I recently found out that when not providing the GuestFormat to a block device mapping, the device will be formated to `vfat` anyway. https://opendev.org/openstack/nova/src/commit/d0b459423dd81644e8d9382b6c87fabaa4f03ad4/nova/privsep/fs.py#L257 I think it's valuable that we document that so the users know what to expect.
pierreprinetti
approved these changes
Oct 24, 2023
Member
pierreprinetti
left a comment
There was a problem hiding this comment.
Thank you: that is extremely valuable input for the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently found out that when not providing the GuestFormat to a block
device mapping, the device will be formated to
vfatanyway.https://opendev.org/openstack/nova/src/commit/d0b459423dd81644e8d9382b6c87fabaa4f03ad4/nova/privsep/fs.py#L257
I think it's valuable that we document that so the users know what to
expect.