Skip to content

Test files alongside code#2818

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
shiftstack:coverage
Oct 20, 2023
Merged

Test files alongside code#2818
EmilienM merged 1 commit intogophercloud:masterfrom
shiftstack:coverage

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Oct 20, 2023

Prior to this patch, all test files sitting alongside the code, outside of a testing directory were ignored by the CI scripts.

Prior to this patch, all test files sitting alongside the code, outside
of a `testing` directory were ignored by the CI scripts.
@github-actions github-actions bot added the semver:patch No API change label Oct 20, 2023
@mandre
Copy link
Copy Markdown
Contributor Author

mandre commented Oct 20, 2023

The unit tests failed as expected, they're fixed in #2815.

@mandre mandre added the backport-v1 This PR will be backported to v1 label Oct 20, 2023
Copy link
Copy Markdown
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmilienM EmilienM merged commit eb27de3 into gophercloud:master Oct 20, 2023
@EmilienM EmilienM deleted the coverage branch October 20, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v1 This PR will be backported to v1 semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants