[v1] Fix options initialization in ServiceClient.Request (fixes #2798)#2800
Merged
[v1] Fix options initialization in ServiceClient.Request (fixes #2798)#2800
Conversation
Request is a part of the public API, but it relies on being called by Get/Post/etc to properly initialize its options. Namely: 1) it may crash on a nil map assignment if there are MoreHeaders, 2) it does not handle microversions. This change moves the relevant code to Request.
mandre
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #2799
Request is a part of the public API, but it relies on being called by
Get/Post/etc to properly initialize its options. Namely:
This change moves the relevant code to Request.