[v1] (manual clean backport) Add tag field to compute block_device_v2#2782
Merged
mandre merged 4 commits intogophercloud:v1from Sep 22, 2023
Merged
[v1] (manual clean backport) Add tag field to compute block_device_v2#2782mandre merged 4 commits intogophercloud:v1from
mandre merged 4 commits intogophercloud:v1from
Conversation
(cherry picked from commit 0e644e4)
(cherry picked from commit f218ca0)
If the client uses a microversion > 2.46, the flavor ID doesn't exist. See https://docs.openstack.org/api-ref/compute/#id30 To avoid complexity when checking the flavor, let's just remove that test. (cherry picked from commit 93e5d0f)
(cherry picked from commit 4fd4c99)
Contributor
Author
|
For CI to work we need #2783 |
mandre
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clean backport with no conflict.
I had to do it manually because the workflow has been fixed after these commits so it didn't run.