Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
|
Thanks for your first contribution ! This looks good to me at a first quick look but I'll come back to it when tests have all passed. |
|
cc @pierreprinetti for a second pair of eyes just in case I missed something in term of best practices. |
pierreprinetti
left a comment
There was a problem hiding this comment.
I am not versed into Heat templates unfortunately. Short of being able to comment what the code does, I have commented how it does it
Add a test that uses a template which itself uses another template, whith templates in different directories so we test the fact that template references are supposed to be relative to the template in which a child template is used (without this, templates wouldn't be composable). Signed-off-by: David Verbeiren <david.verbeiren@tessares.net>
In order for composable stack templates to work, the following changes are needed: * a child template URL must be interpreted as relative to its parent template, not to the base URL * the child templates and 'get_file' of child templates must also be included in the stack create request * the references within child templates (to other templates or files) must be resolved so the correct URLs are provided, matching the files provided in the OS stack create request, just like is done for the top-level template. Signed-off-by: David Verbeiren <david.verbeiren@tessares.net>
5a0f2ac to
8ec15c2
Compare
|
Thanks for the reviews. I believe I have addressed or responded to the comments. I see the tests on OpenStack master have failed. Since the tests on older releases all passed, I assume the problem is rather with OpenStack master. Maybe you want to relaunch the tests? Let me know if there is still something I can do. |
|
tests fail on devstack master because we need to update the version of ubuntu, this is WIP. |
This PR introduces a test where multiple templates are composed, using relative paths. This test currently fails as explained in issue #2735. A second commit fixes the issue.
Fixes #2735