[cinder]: add reset and force delete actions to volumes and snapshots#2696
Merged
mandre merged 1 commit intogophercloud:masterfrom Jul 19, 2023
Merged
[cinder]: add reset and force delete actions to volumes and snapshots#2696mandre merged 1 commit intogophercloud:masterfrom
mandre merged 1 commit intogophercloud:masterfrom
Conversation
d020ef1 to
c66f195
Compare
mandre
reviewed
Jul 19, 2023
Contributor
mandre
left a comment
There was a problem hiding this comment.
Apart from the snapshot bits sneaking into the volume action this is good.
| // ResetStatusOptsBuilder allows extensions to add additional parameters to the | ||
| // ResetStatus request. | ||
| type ResetStatusOptsBuilder interface { | ||
| ToSnapshotResetStatusMap() (map[string]interface{}, error) |
Contributor
There was a problem hiding this comment.
Should be ToResetStatusMap().
Contributor
There was a problem hiding this comment.
There are a few references to snapshots in this file, most probably due to copy & paste.
mandre
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2695