Skip to content

[manila]: add reset and force delete actions to a snapshot#2689

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
kayrus:snapshot-actions
Jul 17, 2023
Merged

[manila]: add reset and force delete actions to a snapshot#2689
EmilienM merged 1 commit intogophercloud:masterfrom
kayrus:snapshot-actions

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Jul 12, 2023

Resolves #2688

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 12, 2023 •
edited
Loading

Coverage Status

coverage: 79.096% (+0.01%) from 79.085% when pulling 514b0d8 on kayrus:snapshot-actions into 48bda5f on gophercloud:master.

@kayrus kayrus mentioned this pull request Jul 12, 2023
Merged
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Jul 12, 2023

@EmilienM @pierreprinetti @mandre ready for review

mandre
mandre previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Jul 13, 2023

@pierreprinetti can we merge this?

@EmilienM EmilienM added the semver:minor Backwards-compatible change label Jul 17, 2023
@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Jul 17, 2023

LGTM too, except there is no acceptance tests. Is it possible to have some?

@kayrus kayrus force-pushed the snapshot-actions branch from 2e1d830 to c7bf8cd Compare July 17, 2023 12:58
@github-actions github-actions bot removed the semver:minor Backwards-compatible change label Jul 17, 2023
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Jul 17, 2023

LGTM too, except there is no acceptance tests. Is it possible to have some?

added. let's hope there is enough permissions to run reset and force delete actions

@kayrus kayrus force-pushed the snapshot-actions branch 4 times, most recently from 836a8ec to 31f4c2b Compare July 17, 2023 14:27
@EmilienM EmilienM added the semver:minor Backwards-compatible change label Jul 17, 2023
EmilienM
EmilienM previously approved these changes Jul 17, 2023
View reviewed changes
EmilienM
EmilienM reviewed Jul 17, 2023
View reviewed changes
@kayrus kayrus force-pushed the snapshot-actions branch from 31f4c2b to 514b0d8 Compare July 17, 2023 16:04
@github-actions github-actions bot removed the semver:minor Backwards-compatible change label Jul 17, 2023
@kayrus kayrus added the semver:minor Backwards-compatible change label Jul 17, 2023
@EmilienM EmilienM merged commit 3df246e into gophercloud:master Jul 17, 2023
@kayrus kayrus deleted the snapshot-actions branch July 17, 2023 16:34
@mandre mandre added the backport-v1 This PR will be backported to v1 label Aug 2, 2023
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM EmilienM approved these changes

@mandre mandre mandre left review comments

Assignees

No one assigned

Labels

backport-v1 This PR will be backported to v1 semver:minor Backwards-compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[manila]: implement reset and force delete actions to a snapshot

4 participants

@kayrus @coveralls @EmilienM @mandre