Skip to content

[v1][CI] Drop periodic jobs from stable branch#2675

Merged
EmilienM merged 1 commit intogophercloud:v1from
shiftstack:drop-periodics
Jul 6, 2023
Merged

[v1][CI] Drop periodic jobs from stable branch#2675
EmilienM merged 1 commit intogophercloud:v1from
shiftstack:drop-periodics

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Jul 6, 2023

Periodic jobs can't run against non-default branches with github action. Remove them from our stable branches to avoid confusion.

According to the github documentation [1]:

Scheduled workflows run on the latest commit on the default or base branch.

[1] https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

Periodic jobs can't run against non-default branches with github
action. Remove them from our stable branches to avoid confusion.

According to the github documentation [1]:

    Scheduled workflows run on the latest commit on the default or base branch.

[1] https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Jul 6, 2023

not 100% necessary but useful for avoiding confusion.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Jul 6, 2023

LGTM, will merge after tests

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 79.05%. remained the same when pulling a0b5dd4 on shiftstack:drop-periodics into efb556a on gophercloud:v1.

@pierreprinetti pierreprinetti added the semver:patch No API change label Jul 6, 2023
@EmilienM EmilienM merged commit b277c7b into gophercloud:v1 Jul 6, 2023
@EmilienM EmilienM deleted the drop-periodics branch July 6, 2023 12:32
@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Jul 6, 2023

backport: #2679

@pierreprinetti
Copy link
Copy Markdown
Member

@EmilienM This patch was merged to v1 directly. What does "backport" mean in this context?

@pierreprinetti pierreprinetti added the v1 This PR targets v1 label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch No API change v1 This PR targets v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants