Skip to content

Add CRUD support for encryption in volume v3 types#2642

Merged
EmilienM merged 3 commits intogophercloud:masterfrom
gebamp:feature/volume_type_encrypt
Jun 28, 2023
Merged

Add CRUD support for encryption in volume v3 types#2642
EmilienM merged 3 commits intogophercloud:masterfrom
gebamp:feature/volume_type_encrypt

Conversation

@gebamp
Copy link
Copy Markdown

@gebamp gebamp commented Jun 7, 2023 •
edited
Loading

Add Create/Delete/Update/Get support for encryption of volume types.

Fixes #2641

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

  1. Create an encryption for a volume type:

  2. Update an encryption for a volume type:

  3. Delete an encryption for a volume type:

  4. Show an encryption for a volume type:

  5. Show an encryption spec for a volume type:

Add CRUD support for encryption in volume v3 types
a365a68 
 Add Create/Delete/Update/Get support for encryption
 of volume types
github-actions[bot]
github-actions bot reviewed Jun 7, 2023
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@gebamp gebamp marked this pull request as draft June 7, 2023 15:54
@gebamp gebamp changed the title WIP: Add CRUD support for encryption in volume v3 types Add CRUD support for encryption in volume v3 types Jun 7, 2023
@gebamp gebamp changed the title Add CRUD support for encryption in volume v3 types [WIP] Add CRUD support for encryption in volume v3 types Jun 8, 2023
@gebamp gebamp marked this pull request as ready for review June 8, 2023 11:36
@gebamp gebamp marked this pull request as draft June 8, 2023 11:50
@gebamp gebamp force-pushed the feature/volume_type_encrypt branch 3 times, most recently from a15b866 to 112a8cb Compare June 12, 2023 10:49
@gebamp gebamp force-pushed the feature/volume_type_encrypt branch from 112a8cb to 8d2245e Compare June 12, 2023 11:17
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 20, 2023

Coverage Status

coverage: 79.097% (+0.06%) from 79.039% when pulling 2267522 on gebamp:feature/volume_type_encrypt into 3fec48d on gophercloud:master.

@gebamp gebamp marked this pull request as ready for review June 20, 2023 16:17
@gebamp gebamp changed the title [WIP] Add CRUD support for encryption in volume v3 types Add CRUD support for encryption in volume v3 types Jun 20, 2023
@gebamp
Copy link
Copy Markdown
Author

gebamp commented Jun 20, 2023

This PR is ready for review, as the acceptance tests that fail are out of the scope of the code included in this PR.

@nikParasyr
Copy link
Copy Markdown
Contributor

nikParasyr commented Jun 26, 2023 •
edited
Loading

@mandre / @pierreprinetti could you have a look at this? we sort of need it.
the failing acceptance tests are not related to this PR

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Jun 28, 2023

CI error is due to a not related error indeed:

2023-06-20T15:50:40.5902347Z === RUN   TestVolumesMultiAttach
2023-06-20T15:50:40.8292534Z     convenience.go:36: �[1;31mFailure in volumes_test.go, line 85: unexpected error �[0m�[1;33m"Bad request with: [POST http://10.1.0.56/volume/v3/ee4787d881734edeb2e7f4d067860ae1/volumes], error message: {\"badRequest\": {\"code\": 400, \"message\": \"multiattach parameter has been removed. The default behavior is to use multiattach enabled volume types. Contact your administrator to create a multiattach enabled volume type and use it to create multiattach volumes.\"}}"�[0m�[1;31m�[0m
2023-06-20T15:50:40.8293891Z --- FAIL: TestVolumesMultiAttach (0.24s)

@EmilienM EmilienM merged commit ea71744 into gophercloud:master Jun 28, 2023
@pierreprinetti pierreprinetti added the backport-v1 This PR will be backported to v1 label Jun 29, 2023
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Closed
@mandre mandre added semver:minor Backwards-compatible change backport-v1 This PR will be backported to v1 and removed backport-v1 This PR will be backported to v1 labels Aug 2, 2023
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@EmilienM EmilienM EmilienM approved these changes

Assignees

No one assigned

Labels

backport-v1 This PR will be backported to v1 semver:minor Backwards-compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

blockstoragev3: support encryption for volumetypes

6 participants

@gebamp @coveralls @nikParasyr @EmilienM @mandre @pierreprinetti