Skip to content

[FWaaS_v2]: Add FWaaS_V2 workflow and enable tests#2637

Merged
mandre merged 7 commits intogophercloud:masterfrom
Koodt:fwaas_v2_add_tests_workflow
Jun 14, 2023
Merged

[FWaaS_v2]: Add FWaaS_V2 workflow and enable tests#2637
mandre merged 7 commits intogophercloud:masterfrom
Koodt:fwaas_v2_add_tests_workflow

Conversation

@Koodt
Copy link
Copy Markdown
Contributor

@Koodt Koodt commented May 30, 2023 •
edited
Loading

Releases below Victoria are deprecated and not testing.
FWaaS_v2 is not compatible with releases below Zed.
FWaaS_v2 has no support for OVN currently and require openvswitch, Q_ML2_PLUGIN_MECHANISM_DRIVERS, Q_ML2_PLUGIN_TYPE_DRIVERS, Q_ML2_TENANT_NETWORK_TYPE and other custom variables.

Add only FWaaS_V2 workflow.
Skip tests for releases below Zed.
Small fix FWaaS_V2 test variable.
Exclude FWaaS_V2 tests from networking workflow acceptance tests filter.

Fixes #2636

Koodt added 3 commits May 30, 2023 14:22
@Koodt
Add FWaaS_v2 workflow.
2bee9ba 
Add FWaaS_v2 workflow for master and Zed.
Skip FWaaS_v2 tests for Openstack releases below Zed.
Fix FWaaS_v2 test variable.
@Koodt
Remove unused overrides
4257931
@Koodt
Rename networking to fwaas_v2
4019c76
@coveralls
Copy link
Copy Markdown

coveralls commented May 30, 2023 •
edited
Loading

Coverage Status

coverage: 79.039% (-0.07%) from 79.108% when pulling 0140149 on Koodt:fwaas_v2_add_tests_workflow into 6e1423b on gophercloud:master.

mandre
mandre reviewed Jun 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine at first glance, but I can't see why the new FWaaS jobs were not triggered. Any idea why the new jobs haven't been picked up?

Also, can you confirm the reason you split these tests out of the networking job was because it requires a different SDN?

@Koodt
Copy link
Copy Markdown
Contributor Author

Koodt commented Jun 13, 2023

@mandre, hi!
I think new workflow doesn't work because it's from fork. I don't have a permissions for view repository settings. Actions permissions have a toggle for "Run workflows from fork pull requests". It's disabled by default.
AISI, it doesn't need to be turned on. Needs merge.

Main reason is develop workflows without complicate by new plugins, huge ACCEPTANCE_TESTS_FILTER and enabled/disabled services.
Also, openstack terraform provider has workflow for each service - vpnaas, fwaas, fwaas_v2.

P.S. I tested this workflow in provider repository.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Jun 14, 2023

@mandre, hi! I think new workflow doesn't work because it's from fork. I don't have a permissions for view repository settings. Actions permissions have a toggle for "Run workflows from fork pull requests". It's disabled by default. AISI, it doesn't need to be turned on. Needs merge.

Main reason is develop workflows without complicate by new plugins, huge ACCEPTANCE_TESTS_FILTER and enabled/disabled services. Also, openstack terraform provider has workflow for each service - vpnaas, fwaas, fwaas_v2.

P.S. I tested this workflow in provider repository.

Cool, thanks. Let's merge it.

@mandre mandre merged commit 44d55f0 into gophercloud:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[fwaas_v2] Add FWaaS_v2 workflow and enable tests above Zed

3 participants

@Koodt @coveralls @mandre