[manila]: Add share from snapshot restore functional test#2629
[manila]: Add share from snapshot restore functional test#2629mandre merged 1 commit intogophercloud:masterfrom
Conversation
7c675c7 to
2e1ab9b
Compare
| if err != nil { | ||
| t.Fatalf("Unable to create a shared file system client: %v", err) | ||
| } | ||
| client.Microversion = "2.27" |
There was a problem hiding this comment.
The microversion doesn't seem right, 2.27 is where revert to snapshot was added, and it looks like that's not what we're using here. The documentation is not explicit about if creating a share from a snapshot also requires microversion 2.27 or not.
Not a big deal really, since we're way past microversion 2.27 (Ocata) anyway.
There was a problem hiding this comment.
The documentation is not explicit about if creating a share from a snapshot also requires microversion 2.27 or not.
It doesn't require it.. creating shares from snapshots was termed "optional" since 2.24 and that part is noted on the doc you linked.. but in general, we're very vary of removing functionality - so unless explicitly stated, using the later micro-version in these tests will give you all the existing behavior ... :)
There was a problem hiding this comment.
but agree with the point here that "restoring from snapshot" here is really "creating share from snapshot" in manila terminology; and confusingly, manila has a feature called "revert_to_snapshot" which allows in-place reverts.. and this "2.27" version seems to come from that.
This PR adds a functional test that restores a snapshot into a bigger share. Primarily this test is required to check whether Manila in devstack is capable to perform such an action.