Limits: Fix ToDo to create registered limit and use it#2627
Merged
mandre merged 1 commit intogophercloud:masterfrom May 24, 2023
Merged
Limits: Fix ToDo to create registered limit and use it#2627mandre merged 1 commit intogophercloud:masterfrom
mandre merged 1 commit intogophercloud:masterfrom
Conversation
mandre
reviewed
May 23, 2023
| // TODO: After https://github.com/gophercloud/gophercloud/issues/2290 is implemented | ||
| // use registered limits API to create global registered limit and then overwrite it with limit. | ||
| // Current solution (using glance limit) only works with Openstack Xena and above. | ||
| clients.SkipReleasesBelow(t, "stable/xena") |
Contributor
There was a problem hiding this comment.
Thanks for doing this. I believe we can also remove the skip below stable/xena as we used that as a workaround for a project that had existing registered limits.
084f97f to
a40cb5e
Compare
Since we have API to create a registered limit, we can use it in the acceptance test to create and then override the same in project. Also simplified fetching service logic since we didn't be depending on glance service anymore.
a40cb5e to
0bda0ef
Compare
mandre
approved these changes
May 24, 2023
Contributor
mandre
left a comment
There was a problem hiding this comment.
Sweet, that seems to work and we can now test on all openstack versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have API to create a registered limit, we can use it in the acceptance test to create and then override the same in project.
Also simplified fetching service logic since we didn't be depending on glance service anymore.