Fix version comparison for acceptance tests#2619
Merged
mandre merged 2 commits intogophercloud:masterfrom May 22, 2023
Merged
Conversation
mandre
commented
May 17, 2023
8cedeaa to
7404b35
Compare
Member
|
EDIT: depends on #2620 |
Contributor
Author
This one, I'm fixing in #2620. |
7404b35 to
d9cdd22
Compare
A couple of functions rely on this environment variable being set.
d9cdd22 to
814ba35
Compare
We want the tests to fail when the required `OS_BRANCH` environment variable is not set.
814ba35 to
72f853b
Compare
pierreprinetti
approved these changes
May 22, 2023
Contributor
Author
|
@pierreprinetti I'm assuming you meant to merge this PR. If not, let me know and I'll revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some acceptance tests rely on a version comparison to conditionally skip tests. It turns out we were not consistently setting the relevant
OS_BRANCHenvironment variable in all the jobs, meaning the version comparison would fail and skip the test.This PR does two things:
OS_BRANCHvariable for all our acceptance jobsOS_BRANCHvariable is not set