Migrate baremetal inventory to a common location#2613
Merged
EmilienM merged 2 commits intogophercloud:masterfrom Aug 12, 2023
Merged
Migrate baremetal inventory to a common location#2613EmilienM merged 2 commits intogophercloud:masterfrom
EmilienM merged 2 commits intogophercloud:masterfrom
Conversation
Contributor
|
@dtantsur thanks for your patch, this is good to me, just rebase it please and I'll merge it. |
Contributor
Author
|
I will, just need to find some time. Rebase won't be trivial, unfortunately. |
With the introduction of the Ironic inventory API, these types are now shared between Ironic and Inspector.
Contributor
Author
|
@EmilienM done! |
EmilienM
approved these changes
Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of the Ironic inventory API, these types are now shared between Ironic and Inspector. No new functionality here yet, posting it to get the refactoring out of my way. Only the documented parts of the introspection data is migrated, not the Inspector-specific ones.
This change is technically breaking since the code is moved around and can no longer be imported at the old locations.
Part of #2612