Make TestMTUNetworkCRUDL deterministic#2593
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Mar 16, 2023
Merged
Conversation
It seems the MTU update API does not returned an object with the `updated_at` field to it's new value. This can cause our test to fail if we check the return of the Update function against the same object retrieved from a Get call, as the `updated_at` field can differ. Instead, just checked for the fields we change in this test. Fix gophercloud#2592
EmilienM
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the MTU update API does not returned an object with the
updated_atfield to it's new value. This can cause our test to fail if we check the return of the Update function against the same object retrieved from a Get call, as theupdated_atfield can differ.Instead, just checked for the fields we change in this test.
Fix #2592