Skip to content

fix: Incorrect Documentation#2587

Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom
Radishaa:Radishaa--Incorrect-Documentation-on-Provider-Network-Create
Mar 10, 2023
Merged

fix: Incorrect Documentation#2587
pierreprinetti merged 1 commit intogophercloud:masterfrom
Radishaa:Radishaa--Incorrect-Documentation-on-Provider-Network-Create

Conversation

@Radishaa
Copy link
Copy Markdown
Contributor

@Radishaa Radishaa commented Mar 10, 2023

fix
issue link

Example are currently missing Equal sign in the CreateOpts.

	createOpts : provider.CreateOptsExt{
		CreateOptsBuilder: networkCreateOpts,
		Segments:          segments,
	}

Thank you for your attention to this matter.

@Radishaa Radishaa mentioned this pull request Mar 10, 2023
Closed
github-actions[bot]
github-actions bot reviewed Mar 10, 2023
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 10, 2023

Coverage Status

Coverage: 79.145%. Remained the same when pulling bd3de14 on Radishaa:Radishaa--Incorrect-Documentation-on-Provider-Network-Create into 36ac4a4 on gophercloud:master.

pierreprinetti
pierreprinetti approved these changes Mar 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pierreprinetti pierreprinetti merged commit afe276b into gophercloud:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@pierreprinetti pierreprinetti pierreprinetti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Radishaa @coveralls @pierreprinetti