Expand docs on 'clientconfig' usage#2558
Merged
pierreprinetti merged 2 commits intogophercloud:masterfrom Feb 20, 2023
Merged
Conversation
Even though this is a separate package, it's helpful to include some minimal documentation for same here rather than insisting folks root through the gophercloud/utils docs. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
Member
|
This is an amazing job and an overdue fix. I have just a nit, commented inline. Thank you! |
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
pierreprinetti
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though this is a separate package, it's helpful to include some minimal documentation for same here rather than insisting folks root through the gophercloud/utils docs.
Fixes #2557