nova: introduce servers.ListSimple along with the more detailed servers.List#2555
Conversation
|
Can you think of a way of adding this functionality in a non-breaking fashion? |
|
@pierreprinetti I'd like to, but it won't be aligned with other services... See my thoughts in the original ticket. |
|
I don't think it's reasonable to merge a fix that breaks existing users for efficiency. If it's not possible to achieve what you need in a backwards-compatible manner, I'd say it's a wontfix. |
|
I know it's a breaking change. But it's breaks for good reasons: align with other It's not the first time gophercloud introduces breaking changes, see https://github.com/gophercloud/gophercloud/blob/master/CHANGELOG.md |
I am not against breaking changes. However they have a cost. Increased efficiency is rarely going to balance that cost. |
|
@pierreprinetti ok. I appreciate if you can suggest a name for a simple list function. |
|
ehr... ListSimple? I hope you are more creative than I am 😬 |
bc0070e to
ad4f2f0
Compare
|
@pierreprinetti done |
|
I renamed the PR to reflect the latest code change. |
|
We merged this a bit too fast. List and ListSimple should be better documented (they currently have the same godoc) and both List and ListSimple should have tests that prove their different behaviour. |
Fixes #2553