Merged
Conversation
EmilienM
previously approved these changes
Jan 25, 2023
Contributor
|
LGTM /cc @mandre |
Contributor
The changelog for v1.2.0 is the output of:
```
gh pr list \
--state merged \
--search 'milestone:v1.2.0' \
--json number,title \
--template \
'{{range .}}* {{ printf "[GH-%v](https://github.com/gophercloud/gophercloud/pull/%v)" .number .number }} {{ .title }}
{{end}}'
```
3bba9b2 to
ece82b5
Compare
EmilienM
previously approved these changes
Jan 27, 2023
Member
Author
The changelog for v1.2.0 is the output of:
```
gh pr list \
--state merged \
--search 'milestone:v1.2.0' \
--json number,title \
--template \
'{{range .}}* {{ printf "[GH-%v](https://github.com/gophercloud/gophercloud/pull/%v)" .number .number }} {{ .title }}
{{end}}'
```
mandre
approved these changes
Jan 27, 2023
Contributor
mandre
left a comment
There was a problem hiding this comment.
We can merge whenever you want @pierreprinetti . Just double check my last commit to see if it's fine with you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultUserAgentas required by Add release instructions #2539