Skip to content

Add tags for loadbalancer l7policy and l7rule#2492

Merged
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:l7_tag
Aug 2, 2023
Merged

Add tags for loadbalancer l7policy and l7rule#2492
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:l7_tag

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

@nikParasyr nikParasyr commented Oct 13, 2022 •
edited
Loading

Tags are supported for octavia l7policy and l7rules since version 2.5. Add support for Create and Update.
Docs

partially implemets: #2381

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 13, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 80.033% when pulling 706597e on nikParasyr:l7_tag into 4ca6fd5 on gophercloud:master.

@nikParasyr nikParasyr force-pushed the l7_tag branch 2 times, most recently from 112c8d8 to 9afe3b2 Compare October 13, 2022 19:43
@nikParasyr
Copy link
Copy Markdown
Contributor Author

nikParasyr commented Oct 17, 2022

@mandre this is rdy from my side as well

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Nov 9, 2022

I'll try my best to clear my backlog of reviews before the end of the week, sorry for the time it takes.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Nov 10, 2022

gorelease reports this change to not be backward compatible and I'm not sure why... @pierreprinetti, do you have an idea?

# github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/l7policies
## incompatible changes
CreateRuleOpts: old is comparable, new is not
Rule: old is comparable, new is not
## compatible changes
CreateOpts.Tags: added
CreateRuleOpts.Tags: added
L7Policy.Tags: added
Rule.Tags: added
UpdateOpts.Tags: added
UpdateRuleOpts.Tags: added

@pierreprinetti
Copy link
Copy Markdown
Member

pierreprinetti commented Nov 23, 2022 •
edited
Loading

This PR changes the signature of the exported functions CreateL7Policy and CreateL7Rule. I am surprised that gorelease does not mention that as a breaking change.

Anyway: structs containing slices cannot be compared. Before this change, the structs Rule and CreateRuleOpts only contained comparable types (string, bool) and a client could have used == on them. Adding a []string breaks such clients.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Nov 24, 2022

This PR changes the signature of the exported functions CreateL7Policy and CreateL7Rule. I am surprised that gorelease does not mention that as a breaking change.

It does, but since they're in acceptance tests we can safely ignore.

Anyway: structs containing slices cannot be compared. Before this change, the structs Rule and CreateRuleOpts only contained comparable types (string, bool) and a client could have used == on them. Adding a []string breaks such clients.

Ack, thanks for your insight.

@mandre mandre added this to the v2.0.0 milestone Feb 23, 2023
@kayrus kayrus mentioned this pull request Mar 5, 2023
Closed
@mandre mandre added the semver:major Breaking change label Jun 30, 2023
@mandre mandre merged commit 0739fff into gophercloud:master Aug 2, 2023
@nikParasyr nikParasyr deleted the l7_tag branch August 2, 2023 07:11
@mandre mandre mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

semver:major Breaking change

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nikParasyr @coveralls @mandre @pierreprinetti