Skip to content

Add service_types support for neutron subnet#2479

Merged
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:service_types
Sep 27, 2022
Merged

Add service_types support for neutron subnet#2479
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:service_types

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

Fixes #2478

Docs

@nikParasyr nikParasyr force-pushed the service_types branch 4 times, most recently from b4472fc to ab6b226 Compare September 21, 2022 08:55
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 21, 2022

Coverage Status

Coverage remained the same at 80.008% when pulling 2ee8cb6 on nikParasyr:service_types into c17fe2c on gophercloud:master.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

@mandre this is rdy from my side. i cant fix the PR label job. There are more PRs with this job failing as well

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the small typo in the docs.

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mandre mandre merged commit 5c912b0 into gophercloud:master Sep 27, 2022
@nikParasyr nikParasyr deleted the service_types branch September 27, 2022 12:47
@pierreprinetti pierreprinetti added this to the v1.1.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for service types on neutron subnets

4 participants