Skip to content

Implementing re-image volumeaction#2474

Merged
mandre merged 1 commit intogophercloud:masterfrom
mfatemipour:blockv3-volumeaction-reimage
Sep 27, 2022
Merged

Implementing re-image volumeaction#2474
mandre merged 1 commit intogophercloud:masterfrom
mfatemipour:blockv3-volumeaction-reimage

Conversation

@mfatemipour
Copy link
Copy Markdown

@mfatemipour mfatemipour commented Sep 10, 2022

github-actions[bot]
github-actions bot reviewed Sep 10, 2022
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 10, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 80.007% when pulling 7ec75f3 on mfatemipour:blockv3-volumeaction-reimage into 2090f9c on gophercloud:master.

@mfatemipour mfatemipour changed the title Implementing re-image volumeaction [WIP] Implementing re-image volumeaction Sep 10, 2022
@mfatemipour mfatemipour force-pushed the blockv3-volumeaction-reimage branch 2 times, most recently from 4e7aa99 to a0d56ba Compare September 10, 2022 19:41
@mfatemipour mfatemipour changed the title [WIP] Implementing re-image volumeaction Implementing re-image volumeaction Sep 10, 2022
@mfatemipour
Copy link
Copy Markdown
Author

mfatemipour commented Sep 10, 2022 •
edited
Loading

os-reimage feature introduced in microversion 3.68 of cinder (yoga) so acceptance tests for other versions failed.
Is there any way to specify target openstack versions for acceptance tests or I should handle it in my code?

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Sep 12, 2022

os-reimage feature introduced in microversion 3.68 of cinder (yoga) so acceptance tests for other versions failed. Is there any way to specify target openstack versions for acceptance tests or I should handle it in my code?

You can use the SkipReleasesBelow() helper function to skip running the test for versions of OpenStack that are not applicable.
Which makes me think, we'll need to go change the implementation of the function as it's soon going to break, with OpenStack release names going back to A 😅

@mfatemipour mfatemipour force-pushed the blockv3-volumeaction-reimage branch from a0d56ba to d8b5fe9 Compare September 12, 2022 15:49
@mfatemipour mfatemipour force-pushed the blockv3-volumeaction-reimage branch from d8b5fe9 to 7ec75f3 Compare September 12, 2022 16:09
@mfatemipour
Copy link
Copy Markdown
Author

mfatemipour commented Sep 12, 2022

hi @mandre, thanks for you help

mandre
mandre approved these changes Sep 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@mandre mandre merged commit f3c89b5 into gophercloud:master Sep 27, 2022
@pierreprinetti pierreprinetti added this to the v1.1.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

Support for re-image volume action

4 participants

@mfatemipour @coveralls @mandre @pierreprinetti