keystone: add v3 limits GetEnforcementModel operation#2470
Merged
mandre merged 2 commits intogophercloud:masterfrom Sep 30, 2022
Merged
keystone: add v3 limits GetEnforcementModel operation#2470mandre merged 2 commits intogophercloud:masterfrom
mandre merged 2 commits intogophercloud:masterfrom
Conversation
Contributor
|
@emilmaruszczak this partially implements #2289. dont close it as there are more apis that need to be implemented. thanks |
Contributor
|
Hi @emilmaruszczak, thanks for the PR. Could you also add acceptance tests, so that we verify the code works against real OpenStack environments? |
Contributor
Author
Hello, sure, will do. |
3b817bf to
bd7ad7c
Compare
bd7ad7c to
4d3ca6e
Compare
mandre
approved these changes
Sep 30, 2022
Contributor
mandre
left a comment
There was a problem hiding this comment.
Thanks for adding the tests. This LGTM. Are you still planning on updating the PR or is it ready to merge?
Contributor
Author
|
It's ready to be merged. |
Contributor
Great, let's go then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2289
docs
code