Skip to content

keystone: add v3 limits update operation#2465

Merged
mandre merged 1 commit intogophercloud:masterfrom
OpenSource-THG:keystone-limits-update
May 16, 2023
Merged

keystone: add v3 limits update operation#2465
mandre merged 1 commit intogophercloud:masterfrom
OpenSource-THG:keystone-limits-update

Conversation

@emilmaruszczak
Copy link
Copy Markdown
Contributor

@emilmaruszczak emilmaruszczak commented Sep 6, 2022

For #2289

docs
code

This is a base for detail and delete operations code I prepared.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 6, 2022

Coverage Status

Coverage: 80.095% (-0.0008%) from 80.096% when pulling 39b70b7 on OpenSource-THG:keystone-limits-update into 49ee5b4 on gophercloud:master.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Sep 28, 2022

Hi @emilmaruszczak, thanks for your work on #2289. Just so that we know, do you have more PRs in stock for identity v3 limits?
I already mentioned it in your other PR, it would be really nice if you could add acceptance tests. This way we can ensure the code works for all supported versions of openstack. Thanks.

@emilmaruszczak
Copy link
Copy Markdown
Contributor Author

Hi @emilmaruszczak, thanks for your work on #2289. Just so that we know, do you have more PRs in stock for identity v3 limits? I already mentioned it in your other PR, it would be really nice if you could add acceptance tests. This way we can ensure the code works for all supported versions of openstack. Thanks.

Hey, yes, I do have all the other operations implemented - I am not pushing them out because they depend on these operations models and so I think it's easier for the merging and reviwing.

I'll add the acceptance tests to all operations as well.

@emilmaruszczak emilmaruszczak force-pushed the keystone-limits-update branch 2 times, most recently from 39b70b7 to 3db14ec Compare February 6, 2023 10:02
@emilmaruszczak emilmaruszczak force-pushed the keystone-limits-update branch from 3db14ec to 9606940 Compare May 15, 2023 11:50
@emilmaruszczak emilmaruszczak force-pushed the keystone-limits-update branch from 9606940 to 4f9320f Compare May 16, 2023 08:39
@emilmaruszczak
Copy link
Copy Markdown
Contributor Author

@mandre this is ready to be merged in.

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I kept count correctly, the last remaining thing for #2289 is the delete call?

@mandre mandre merged commit f41487e into gophercloud:master May 16, 2023
@mandre mandre added this to the v1.4.0 milestone May 16, 2023
@emilmaruszczak
Copy link
Copy Markdown
Contributor Author

If I kept count correctly, the last remaining thing for #2289 is the delete call?

You are right, #2618 is ready, waiting for actions to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants