Skip to content

Add support for standard-attr-revisions to core network components#2437

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
andreaskaris:neutron-revision-support
Jul 18, 2022
Merged

Add support for standard-attr-revisions to core network components#2437
EmilienM merged 1 commit intogophercloud:masterfrom
andreaskaris:neutron-revision-support

Conversation

@andreaskaris
Copy link
Copy Markdown
Contributor

@andreaskaris andreaskaris commented Jul 14, 2022

The Resource revision numbers extension allows tracking if an object was
updated since it was last retrieved. Add support for revision numbers
for the 3 core networking objects (networks, subnets, ports).

Signed-off-by: Andreas Karis ak.karis@gmail.com

Prior to starting a PR, please make sure you have read our
contributor tutorial.

Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.

Fixes #2438

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/network/v2/index.html?expanded=list-api-versions-detail,list-extensions-detail,show-extension-details-detail

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 14, 2022

Coverage Status

Coverage decreased (-0.01%) to 79.976% when pulling 1a63a93 on andreaskaris:neutron-revision-support into 5b4f7ed on gophercloud:master.

The Resource revision numbers extension allows tracking if an object was
updated since it was last retrieved. Add support for revision numbers
for the 3 core networking objects (networks, subnets, ports).

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@EmilienM
Copy link
Copy Markdown
Contributor

Excellent work, thanks!
LGTM

@EmilienM EmilienM merged commit 0721d75 into gophercloud:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

neutron: Add support for resource revision number extension and if-match HTTP header

3 participants