Neutron v2: AddGatewayNetwork, RemoveGatewayNetwork and GetAdvertised… by shhgs · Pull Request #2406 · gophercloud/gophercloud

shhgs · 2022-05-20T18:33:41Z

Neutron V2: BGP Dynamic Routing
For #2208

$ git diff --stat official/master                                                                                                                      
 acceptance/openstack/networking/v2/extensions/bgp/speakers/bgpspeakers_test.go | 27 +++++++++++++++++++++++++++                                                                                                   
 openstack/networking/v2/extensions/bgp/speakers/doc.go                         | 42 ++++++++++++++++++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/speakers/requests.go                    | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/speakers/results.go                     | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/speakers/testing/fixture.go             | 25 +++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/speakers/testing/requests_test.go       | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/speakers/urls.go                        | 15 +++++++++++++++
 7 files changed, 307 insertions(+)

shhgs · 2022-05-20T18:38:53Z

This is the last PR for bgp/speakers. There will still be one (hopefully) PR for agents, a.k.a. /v2.0/agents/{agent-id}/bgp-drinstances.

coveralls · 2022-05-20T18:42:06Z

Coverage increased (+0.02%) to 79.987% when pulling b957a55 on shhgs:2022-05-20 into c596f3b on gophercloud:master.

mandre · 2022-05-24T14:33:20Z

openstack/networking/v2/extensions/bgp/speakers/doc.go

+Example:
+
+
+	opts := speakers.AddGatewayNetworkOpts{NetworkID: networkID}


Nit: it looks like you have a mix of tabs and spaces.

Suggested change

opts := speakers.AddGatewayNetworkOpts{NetworkID: networkID}

opts := speakers.AddGatewayNetworkOpts{NetworkID: networkID}

Fixed the issue.

mandre · 2022-05-24T14:34:07Z

openstack/networking/v2/extensions/bgp/speakers/doc.go

+
+Example:
+
+	opts := speakers.RemoveGatewayNetworkOpts{NetworkID: networkID}


ditto

Suggested change

opts := speakers.RemoveGatewayNetworkOpts{NetworkID: networkID}

opts := speakers.RemoveGatewayNetworkOpts{NetworkID: networkID}

mandre · 2022-05-24T14:36:00Z

openstack/networking/v2/extensions/bgp/speakers/requests.go

 	return
 }
+
+// GetAdvertisedRoutes a.k.a. GET /v2.0/bgp-speakers/{bgp-speaker-id}/bgp-dragents


Suggested change

// GetAdvertisedRoutes a.k.a. GET /v2.0/bgp-speakers/{bgp-speaker-id}/bgp-dragents

// GetAdvertisedRoutes a.k.a. GET /bgp-speakers/{id}/get_advertised_routes

mandre · 2022-05-24T14:41:49Z

openstack/networking/v2/extensions/bgp/speakers/requests.go

+}
+
+// AddGatewayNetwork a.k.a. PUT /v2.0/bgp-speakers/{bgp-speaker-id}/add_gateway_network
+func AddGatewayNetwork(c *gophercloud.ServiceClient, bgpSpeakerID string, opts AddGatewayNetworkOpts) (r AddGatewayNetworkResult) {


Same comment as in #2400, we should make use of the AddGatewayNetworkOptsBuilder interface.

mandre · 2022-05-24T14:43:57Z

openstack/networking/v2/extensions/bgp/speakers/requests.go

+}
+
+// RemoveGatewayNetwork a.k.a. PUT /v2.0/bgp-speakers/{bgp-speaker-id}/remove_gateway_network
+func RemoveGatewayNetwork(c *gophercloud.ServiceClient, bgpSpeakerID string, opts RemoveGatewayNetworkOpts) (r RemoveGatewayNetworkResult) {


Same for the RemoveGatewayNetworkOptsBuilder interface.

…Routes

shhgs · 2022-05-24T18:00:16Z

Thanks @mandre, I fixed the problems you pointed.

mandre

LGTM

shhgs force-pushed the 2022-05-20 branch from df17f13 to 03d44c8 Compare May 24, 2022 12:46

mandre reviewed May 24, 2022

View reviewed changes

Neutron v2: AddGatewayNetwork, RemoveGatewayNetwork and GetAdvertised…

b957a55

…Routes

shhgs force-pushed the 2022-05-20 branch from 03d44c8 to b957a55 Compare May 24, 2022 17:59

mandre approved these changes May 26, 2022

View reviewed changes

mandre merged commit d987a08 into gophercloud:master May 26, 2022

		Example:


		opts := speakers.AddGatewayNetworkOpts{NetworkID: networkID}


		Example:

		opts := speakers.RemoveGatewayNetworkOpts{NetworkID: networkID}

	// GetAdvertisedRoutes a.k.a. GET /v2.0/bgp-speakers/{bgp-speaker-id}/bgp-dragents
	// GetAdvertisedRoutes a.k.a. GET /bgp-speakers/{id}/get_advertised_routes

Conversation

shhgs commented May 20, 2022

Uh oh!

shhgs commented May 20, 2022

Uh oh!

coveralls commented May 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shhgs commented May 24, 2022

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coveralls commented May 20, 2022 •

edited

Loading