Skip to content

Neutron v2: BGP Peer Update#2396

Merged
mandre merged 1 commit intogophercloud:masterfrom
shhgs:2022-05-09
May 10, 2022
Merged

Neutron v2: BGP Peer Update#2396
mandre merged 1 commit intogophercloud:masterfrom
shhgs:2022-05-09

Conversation

@shhgs
Copy link
Copy Markdown
Contributor

@shhgs shhgs commented May 9, 2022

Neutron V2: BGP Dynamic Routing
For #2208

$ git diff --stat official/master                                                                                                                      
 acceptance/openstack/networking/v2/extensions/bgp/peers/bgppeers_test.go | 35 ++++++++++++++++++++++++-----------                                                                                                 
 openstack/networking/v2/extensions/bgp/peers/doc.go                      | 14 ++++++++++++++
 openstack/networking/v2/extensions/bgp/peers/requests.go                 | 33 ++++++++++++++++++++++++++++++++-
 openstack/networking/v2/extensions/bgp/peers/results.go                  |  6 ++++++
 openstack/networking/v2/extensions/bgp/peers/testing/fixture.go          | 23 +++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/peers/testing/requests_test.go    | 27 +++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/peers/urls.go                     |  5 +++++
 7 files changed, 131 insertions(+), 12 deletions(-)

@coveralls
Copy link
Copy Markdown

coveralls commented May 9, 2022

Coverage Status

Coverage increased (+0.002%) to 79.953% when pulling 692915d on shhgs:2022-05-09 into 0ace4a5 on gophercloud:master.

mandre
mandre approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. Is that the last of it, or more are coming? If it's the last one, you may consider updating the PR description to use a keyword that would close #2208 upon merging.

@shhgs
Copy link
Copy Markdown
Contributor Author

shhgs commented May 10, 2022

More to come. I think we need 2 extra PR. One for BGP Speaker update and the other for the scheduleing of BGP speaker to the bgp agent.

@mandre mandre merged commit 1d17ee7 into gophercloud:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shhgs @coveralls @mandre