Skip to content

Neutron v2: BGP Peer create / delete#2388

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
shhgs:20220428
May 4, 2022
Merged

Neutron v2: BGP Peer create / delete#2388
EmilienM merged 1 commit intogophercloud:masterfrom
shhgs:20220428

Conversation

@shhgs
Copy link
Copy Markdown
Contributor

@shhgs shhgs commented Apr 30, 2022

Neutron V2: BGP VPNs
For #2209

Add Create/Delete method for bgp/peers

$ git diff --stat HEAD^                                                                                                                                   
 acceptance/openstack/networking/v2/extensions/bgp/peers/bgppeers_test.go | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++                                                                  
 acceptance/openstack/networking/v2/extensions/bgp/peers/doc.go           |  2 ++
 openstack/networking/v2/extensions/bgp/peers/doc.go                      | 25 +++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/peers/requests.go                 | 39 +++++++++++++++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/peers/results.go                  | 12 ++++++++++++
 openstack/networking/v2/extensions/bgp/peers/testing/fixture.go          | 26 ++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/peers/testing/requests_test.go    | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 openstack/networking/v2/extensions/bgp/peers/urls.go                     | 10 ++++++++++
 8 files changed, 227 insertions(+)

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 30, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 79.945% when pulling 3759902 on shhgs:20220428 into 84a4f7a on gophercloud:master.

@shhgs
Copy link
Copy Markdown
Contributor Author

shhgs commented Apr 30, 2022

I think the environment does not have this feature and therefore cause the acceptance test to fail.

2022-04-30T03:28:57.3399121Z === RUN   TestBGPPeerCRD
2022-04-30T03:28:57.3945356Z     convenience.go:35: Failure in bgppeers_test.go, line 41: unexpected error "Resource not found: [GET http://10.1.0.157:9696/v2.0/bgp-peers], error message: {\"NeutronError\": {\"type\": \"HTTPNotFound\", \"message\": \"The resource could not be found.\", \"detail\": \"\"}}"
2022-04-30T03:28:57.3946827Z --- FAIL: TestBGPPeerCRD (0.05s)
2022-04-30T03:28:57.3947439Z FAIL
2022-04-30T03:28:57.3977644Z FAIL       github.com/gophercloud/gophercloud/acceptance/openstack/networking/v2/extensions/bgp/peers      0.059s
2022-04-30T03:28:57.3978236Z FAIL

@shhgs
Copy link
Copy Markdown
Contributor Author

shhgs commented Apr 30, 2022

I tested it on our lab and it works.

 go test -v -tags "fixtures acceptance" -run TestBGPPeerCRD github.com/gophercloud/gophercloud/acceptance/openstack/networking/v2/extensions/bgp/peers            
=== RUN   TestBGPPeerCRD
    bgppeers_test.go:46: Retrieved BGP Peers
    tools.go:80: [
          {
            "auth_type": "none",
            "id": "5e089384-0837-40ee-97c0-f4436c330e52",
            "name": "peer-external-1",
            "tenant_id": "428f153e8b0743699d6bb335fde0a75d",
            "peer_ip": "10.173.254.251",
            "project_id": "428f153e8b0743699d6bb335fde0a75d",
            "remote_as": 64799
          },
          {
            "auth_type": "none",
            "id": "5f89e0ad-7223-4757-a6bd-1ae26ba9f575",
            "name": "peer-external-2",
            "tenant_id": "428f153e8b0743699d6bb335fde0a75d",
            "peer_ip": "10.173.254.253",
            "project_id": "428f153e8b0743699d6bb335fde0a75d",
            "remote_as": 64799
          }
        ]
    bgppeers_test.go:21: Attempting to create BGP Peer: TESTACC-BGPPEER-MACpnwHI
    bgppeers_test.go:27: Successfully created BGP Peer
    tools.go:80: {
          "auth_type": "md5",
          "id": "273e7de0-6b29-43f6-9078-63a8213c4971",
          "name": "TESTACC-BGPPEER-MACpnwHI",
          "tenant_id": "428f153e8b0743699d6bb335fde0a75d",
          "peer_ip": "192.168.0.1",
          "project_id": "428f153e8b0743699d6bb335fde0a75d",
          "remote_as": 1047
        }
    bgppeers_test.go:59: Attempting to delete BGP Peer: TESTACC-BGPPEER-MACpnwHI
    bgppeers_test.go:65: BGP Peer TESTACC-BGPPEER-MACpnwHI deleted
--- PASS: TestBGPPeerCRD (0.46s)
PASS
ok      github.com/gophercloud/gophercloud/acceptance/openstack/networking/v2/extensions/bgp/peers      0.461s

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented May 3, 2022

Please enable what needs to be enabled via https://github.com/gophercloud/gophercloud/blob/master/.github/workflows/functional-networking.yaml#L57

Thanks

@shhgs shhgs force-pushed the 20220428 branch 2 times, most recently from 6ab1fde to 4757f29 Compare May 4, 2022 01:20
@shhgs
Copy link
Copy Markdown
Contributor Author

shhgs commented May 4, 2022

Hi @EmilienM

I fixed the devstack config and it passed the acceptance test.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented May 4, 2022

@shhgs nice work, I could confirm by reading the logs that you enabled dynamic routing and the tests ran successfully!
I'll review this patch asap again.

@EmilienM EmilienM merged commit d800237 into gophercloud:master May 4, 2022
@shhgs shhgs mentioned this pull request May 4, 2022
Merged
@mandre mandre mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shhgs @coveralls @EmilienM