Skip to content

Add missing fields in Objectstorage and compute API#2387

Merged
pierreprinetti merged 2 commits intogophercloud:masterfrom
pdesgarets:master
Dec 18, 2024
Merged

Add missing fields in Objectstorage and compute API#2387
pierreprinetti merged 2 commits intogophercloud:masterfrom
pdesgarets:master

Conversation

@pdesgarets
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.939% when pulling f8b21a4 on pdesgarets:master into 19ba3dc on gophercloud:master.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Apr 29, 2022

bonjour @pdesgarets :-)

Thanks for your pull request.
Usually, we do one pull request per issue. But I'm not sure, so I'll be ok with the way it is now, just keep in mind for the next ones ;-)

For this PR, I see it has unit tests, thanks. It'll be great to also have acceptance coverage. Let me know if you need help for that.

Thanks!

@pdesgarets
Copy link
Copy Markdown
Contributor Author

OK, thanks for the review, I'll try to add acceptance tests, that may require some additional time

@CloudCourierStation
Copy link
Copy Markdown
Contributor

Hello, may I ask if you are willing to further improve this PR? Now I have some requirements for Server Lock Status @pdesgarets

@pdesgarets
Copy link
Copy Markdown
Contributor Author

Hi, I currently lack of free time, feel free to start from by branch and add the needed acceptance tests

@github-actions github-actions bot added edit:compute This PR updates compute code edit:objectstorage This PR updates objectstorage code semver:minor Backwards-compatible change labels Sep 26, 2024
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 78.716%. remained the same
when pulling cec507c on pdesgarets:master
into faa8108 on gophercloud:master.

@pierreprinetti pierreprinetti added the just-needs-tests This PR lacks tests before it can be merged label Sep 26, 2024
@pierreprinetti pierreprinetti merged commit b747927 into gophercloud:master Dec 18, 2024
@pierreprinetti pierreprinetti added the backport-v2 This PR will be backported to v2 label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:compute This PR updates compute code edit:objectstorage This PR updates objectstorage code just-needs-tests This PR lacks tests before it can be merged semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compute v2 : Missing "locked" field

5 participants