baremetal: add API to set maintenance and maintenance reason#2384
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Apr 21, 2022
Merged
baremetal: add API to set maintenance and maintenance reason#2384EmilienM merged 1 commit intogophercloud:masterfrom
EmilienM merged 1 commit intogophercloud:masterfrom
Conversation
61 tasks
Contributor
|
@dtantsur thanks for your PR :-) |
Contributor
Author
|
Yep, working on exactly that (struggling to even compile anything locally, meh) |
a965aec to
558cdc6
Compare
Contributor
Author
|
Okay, this has acceptance tests (that I couldn't verify locally, so may not even compile). I'll look into fixtures tomorrow, need to understand what they are. |
558cdc6 to
a21e54c
Compare
For very historical reasons, Ironic requires a special API to set them. While the maintenance itself can be set directly (for even more historical reasons), the reason cannot.
a21e54c to
a2b4532
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2383
See https://docs.openstack.org/api-ref/baremetal/?expanded=set-maintenance-flag-detail,clear-maintenance-flag-detail#set-maintenance-flag for API reference.