Skip to content

Add ParentProviderUUID to resourceProvider#2356

Merged
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:placement_update
Mar 18, 2022
Merged

Add ParentProviderUUID to resourceProvider#2356
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:placement_update

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

Add ParentProviderUUID to placement/v1/resourceproviders createOpts.
Moreover restructure acceptance tests for consistency and for future
additions.

Docs

Relates to: #526

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 23, 2022

Coverage Status

Coverage remained the same at 79.893% when pulling ddfa463 on nikParasyr:placement_update into beef396 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 23, 2022

Build succeeded.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

not sure about the updates on the ci that have been done the last months but this was blazing fast. GJ :)

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like to take a look at your other PRs before merging this one.

FYI, the placement acceptance tests still run on openlab. I'm moving them to github action with #2363, so expect them to run a lot faster really soon ⚡

Add ParentProviderUUID to placement/v1/resourceproviders createOpts.
Moreover restructure acceptance tests for consistency and for future
additions.

[Docs](https://docs.openstack.org/api-ref/placement/?expanded=create-resource-provider-detail)

Relates to: gophercloud#526
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 18, 2022

Build succeeded.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

@mandre / @EmilienM rebased this one all the following MRs, it's ready from my side. Thanks :)

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@mandre mandre merged commit 3669a1f into gophercloud:master Mar 18, 2022
@nikParasyr nikParasyr deleted the placement_update branch October 13, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants