Merged
Conversation
|
Build failed.
|
2 tasks
mandre
reviewed
Feb 26, 2022
Contributor
mandre
left a comment
There was a problem hiding this comment.
Thanks for the PR. This looks good, but I noticed we're also missing the user_id field in the response. Could you perhaps also add it as well?
| Members []string `json:"members"` | ||
|
|
||
| // ProjectID of the server group. | ||
| ProjectID string `json:"project_id"` |
Contributor
There was a problem hiding this comment.
While you're there, could you also add the missing user_id field?
Contributor
Author
There was a problem hiding this comment.
amended and force pushed.
5b07ef7 to
2623777
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2354
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/compute/?expanded=list-server-groups-detail#id340
https://docs.openstack.org/api-ref/compute/?expanded=list-server-groups-detail#id341