Skip to content

Update loadbalancer/v2/l7policies create and update#2324

Merged
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:redirect_prefix
Jan 21, 2022
Merged

Update loadbalancer/v2/l7policies create and update#2324
mandre merged 1 commit intogophercloud:masterfrom
nikParasyr:redirect_prefix

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

Add REDIRECT_PREFIX and REDIRECT_HTTP_CODE to l7policy
CreateOpts and UpdateOpts.
Docs: https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-an-l7-policy-detail,update-a-l7-policy-detail#create-an-l7-policy
Fixes: #2322

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 18, 2022

Coverage Status

Coverage decreased (-0.01%) to 79.91% when pulling 27b4c75 on nikParasyr:redirect_prefix into b8cd8d7 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 18, 2022

Build failed.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 19, 2022

Build failed.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

@EmilienM can you have a look? The failing tests seem to be "irrelevant" afaik, but maybe im missing something

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilienM can you have a look? The failing tests seem to be "irrelevant" afaik, but maybe im missing something

Correct, the failing tests are all in acceptance/openstack/networking/v2/extensions/qos and unrelated to your patch.

Could you just add the redirect_prefix and redirect_http_code fields to results.go as well?

@nikParasyr
Copy link
Copy Markdown
Contributor Author

Could you just add the redirect_prefix and redirect_http_code fields to results.go as well?

@mandre done! Thanks :)

@nikParasyr nikParasyr requested a review from mandre January 21, 2022 09:18
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now 👍

Let's just wait for CI to come back.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 21, 2022

Build failed.

@mandre mandre merged commit 145cbdc into gophercloud:master Jan 21, 2022
@mandre
Copy link
Copy Markdown
Contributor

mandre commented Jan 21, 2022

Same 5 failures in qos acceptance tests, something's off with that job but it's not related to your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

L7Policy: Action REDIRECT_PREFIX

3 participants