Add Missing Neutron v2 Protocol Constant "any"#2310
Merged
EmilienM merged 2 commits intogophercloud:masterfrom Jan 9, 2022
HappyFX:master
Merged
Add Missing Neutron v2 Protocol Constant "any"#2310EmilienM merged 2 commits intogophercloud:masterfrom HappyFX:master
EmilienM merged 2 commits intogophercloud:masterfrom
HappyFX:master
Conversation
Add option "Any" in security group rules, according the [documentaion](https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/security-group-rule.html#cmdoption-openstack-security-group-rule-create-protocol): ```bash Network version 2: IP protocol (ah, dccp, egp, esp, gre, icmp, igmp, ipv6-encap, ipv6-frag, ipv6-icmp, ipv6-nonxt, ipv6-opts, ipv6-route, ospf, pgm, rsvp, sctp, tcp, udp, udplite, vrrp and integer representations [0-255] or any; default: any (all protocols)) ```
|
Build failed.
|
Contributor
Author
|
I believe the broken test due QoS neutron changes: openstack/neutron@cf8fa0d |
EmilienM
reviewed
Jan 8, 2022
|
Build failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option "Any" in security group rules, according the documentation:
Network version 2: IP protocol (ah, dccp, egp, esp, gre, icmp, igmp, ipv6-encap, ipv6-frag, ipv6-icmp, ipv6-nonxt, ipv6-opts, ipv6-route, ospf, pgm, rsvp, sctp, tcp, udp, udplite, vrrp and integer representations [0-255] or any; default: any (all protocols))Fixes #2309
In code neutron
None- wildcard, but in documentation it mention asanyLinks to the line numbers/files in the OpenStack source code that support the
code in this PR:
openstack/python-openstackclient@82f45d9
https://github.com/openstack/neutron/blob/1ad9ca56b07ffdc9f7e0bc6a62af61961b9128eb/neutron/extensions/securitygroup.py#L211
https://github.com/openstack/neutron/blob/1ad9ca56b07ffdc9f7e0bc6a62af61961b9128eb/neutron/extensions/securitygroup.py#L151