Identity v3: add support for OS-EP-FILTER (endpoint) extension #2303#2304
Merged
EmilienM merged 2 commits intogophercloud:masterfrom Jan 11, 2022
Merged
Identity v3: add support for OS-EP-FILTER (endpoint) extension #2303#2304EmilienM merged 2 commits intogophercloud:masterfrom
EmilienM merged 2 commits intogophercloud:masterfrom
Conversation
2442326 to
c3ecbfe
Compare
|
Build succeeded.
|
Contributor
|
@snigle Hey Ludovic, the code looks good to me (merci!) but i was wondering if there was a specific reason to NOT have acceptance tests part of the PR? Is that something that you could add ? Thanks |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2303
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/identity/v3-ext/?expanded=list-associations-by-project-detail#list-associations-by-project
https://github.com/openstack/keystone/blob/ba2e4b83e88d5c1576e9d2cd6a760367deef3a62/keystone/api/os_ep_filter.py#L145-L154