Skip to content

Bump Go to 1.14#2294

Merged
EmilienM merged 6 commits intogophercloud:masterfrom
shiftstack:goversions
Dec 10, 2021
Merged

Bump Go to 1.14#2294
EmilienM merged 6 commits intogophercloud:masterfrom
shiftstack:goversions

Conversation

@pierreprinetti
Copy link
Copy Markdown
Member

@pierreprinetti pierreprinetti commented Dec 10, 2021 •
edited
Loading

This PR contains several little changes to the test definitions:

  • Test against Go 1.14 (the oldest supported version) and Go tip
  • Let the Goveralls GH action deal with the Goveralls installation
  • Use ubuntu-latest in tests instead of pinning to an arbitrary version
  • Remove a (probably) unneeded explicit install of crypto/ssh
  • Run scripts/unittest in a separate workflow, to increase readability and parallelise work

Additionally, it turns out that we are using in testhelper a method that was introduced in Go 1.14. With this PR, I propose to bump the minimum acceptable version of Go to v1.14 in go.mod.

@pierreprinetti pierreprinetti changed the title Goversions Actions little tweaks Dec 10, 2021
@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Dec 10, 2021

LGTM
will wait on CI to merge it.

@pierreprinetti
Copy link
Copy Markdown
Member Author

pierreprinetti commented Dec 10, 2021

@EmilienM Please note that I have now bumped Go to v1.14 in go.mod

@pierreprinetti pierreprinetti changed the title Actions little tweaks Bump Go to 1.14 Dec 10, 2021
@pierreprinetti
test: Run reauth tests separately
4c88bfb 
Running retests in a separate action to increase explicitness and to
parallelise WRT to the other unit tests.
@pierreprinetti
Set Go minimum version to 1.14
e2ccc7b 
The `testhelper` package uses `http.Header`'s method `Values`, which
[was introduced in GO 1.14][1].

[1]: https://pkg.go.dev/net/http#Header.Values
@pierreprinetti pierreprinetti force-pushed the goversions branch 2 times, most recently from 901bf34 to b3d2520 Compare December 10, 2021 15:11
@pierreprinetti
test: Run go fmt ./...
cfaf0b7 
The syntax for build hints has slightly changed and gofmt complains.
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 10, 2021

Coverage Status

Coverage remained the same at 79.894% when pulling cfaf0b7 on shiftstack:goversions into 8780806 on gophercloud:master.

@EmilienM EmilienM merged commit 18a1ee5 into gophercloud:master Dec 10, 2021
@EmilienM EmilienM deleted the goversions branch December 10, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian Awaiting requested review from jtopjian

@EmilienM EmilienM Awaiting requested review from EmilienM

@mandre mandre Awaiting requested review from mandre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierreprinetti @EmilienM @coveralls