Skip to content

blockstorage/v3/qos Add Get, Update and Delete Keys#2283

Merged
EmilienM merged 3 commits intogophercloud:masterfrom
nikParasyr:qos_get
Nov 26, 2021
Merged

blockstorage/v3/qos Add Get, Update and Delete Keys#2283
EmilienM merged 3 commits intogophercloud:masterfrom
nikParasyr:qos_get

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

Partially implements: #2139

Implements Get, Update and DeleteKeys

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

Get: api docs, code

Update: api docs schema, code

DeleteKeys: api docs, schema, code

@nikParasyr
Copy link
Copy Markdown
Contributor Author

@EmilienM not sure if i should ping you on MRs, now with the change of guard. In any case 👇

Note for Update: This api call is a bit strange. This was discussed a bit during the Create where it was decided to have Consumer as a seperate field and the rest under Specs. Name cannot be updated. I decided to implement it in a similar way with Create. Unfortunately the response doesn't return the full QoS. The links above should be helpful.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 79.877% when pulling 2f8fb3f on nikParasyr:qos_get into fbf1f72 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Nov 26, 2021

Build succeeded.

@EmilienM
Copy link
Copy Markdown
Contributor

@EmilienM not sure if i should ping you on MRs, now with the change of guard. In any case point_down

Note for Update: This api call is a bit strange. This was discussed a bit during the Create where it was decided to have Consumer as a seperate field and the rest under Specs. Name cannot be updated. I decided to implement it in a similar way with Create. Unfortunately the response doesn't return the full QoS. The links above should be helpful.

Hello!
You can ping me anytime, I have no problem with it.
Thanks for the PR, I'll add it to my review list.

@EmilienM EmilienM changed the title blockstorage/v3/qos Add Get,Update and DeleteKeys blockstorage/v3/qos Add Get, Update and Delete Keys Nov 26, 2021
@EmilienM EmilienM merged commit 8163f89 into gophercloud:master Nov 26, 2021
@nikParasyr nikParasyr deleted the qos_get branch December 7, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants