You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@EmilienM not sure if i should ping you on MRs, now with the change of guard. In any case 👇
Note for Update: This api call is a bit strange. This was discussed a bit during the Create where it was decided to have Consumer as a seperate field and the rest under Specs. Name cannot be updated. I decided to implement it in a similar way with Create. Unfortunately the response doesn't return the full QoS. The links above should be helpful.
@EmilienM not sure if i should ping you on MRs, now with the change of guard. In any case point_down
Note for Update: This api call is a bit strange. This was discussed a bit during the Create where it was decided to have Consumer as a seperate field and the rest under Specs. Name cannot be updated. I decided to implement it in a similar way with Create. Unfortunately the response doesn't return the full QoS. The links above should be helpful.
Hello!
You can ping me anytime, I have no problem with it.
Thanks for the PR, I'll add it to my review list.
EmilienM
changed the title
blockstorage/v3/qos Add Get,Update and DeleteKeys
blockstorage/v3/qos Add Get, Update and Delete Keys
Nov 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially implements: #2139
Implements
Get,UpdateandDeleteKeysLinks to the line numbers/files in the OpenStack source code that support the
code in this PR:
Get: api docs, codeUpdate: api docs schema, codeDeleteKeys: api docs, schema, code