Skip to content

octavia: add new pool monitor types#2261

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
kayrus:octavia-new-monitors
Nov 5, 2021
Merged

octavia: add new pool monitor types#2261
EmilienM merged 1 commit intogophercloud:masterfrom
kayrus:octavia-new-monitors

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Nov 5, 2021

resolves #2260

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.862% when pulling 102e0d9 on kayrus:octavia-new-monitors into 3889f57 on gophercloud:master.

@kayrus kayrus changed the title octavia: add new poolmonitor types octavia: add new pool monitor types Nov 5, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Nov 5, 2021

Build failed.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Nov 5, 2021

I confirm that these values are supported by Octavia:
https://github.com/openstack/octavia-lib/blob/master/octavia_lib/common/constants.py#L50-L56

And used by Octavia when creating the listeners.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Nov 5, 2021

this LGTM and safe to land without the acceptance test.
note that this won't work when the backend is OVN, as it doesn't support Health monitors. However, this would return a proper error if anyone tried to created a health monitor when LB is backed by OVN, so nothing to to in Gophercloud I think.
thanks!

@EmilienM EmilienM merged commit 2cf8e4c into gophercloud:master Nov 5, 2021
@kayrus kayrus deleted the octavia-new-monitors branch November 5, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Octavia: add new pool members monitor types

3 participants