identity v3: extend role assignments values with domain info#2235
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Oct 14, 2021
Merged
identity v3: extend role assignments values with domain info#2235jtopjian merged 2 commits intogophercloud:masterfrom
jtopjian merged 2 commits intogophercloud:masterfrom
Conversation
|
Build failed.
|
Contributor
|
@kayrus Thanks. Can you add unit tests and acceptance tests for completeness? I know OpenLab is broke right now, but I can run the test locally. The output you provided in #2234 was pretty close, but it was missing "proof" about the Group data. I dug this up to help speed this along: https://github.com/openstack/keystone/blob/master/keystone/api/role_assignments.py#L206-L361 |
|
Build failed.
|
Contributor
Author
|
@jtopjian added unit and acceptance tests |
|
Build failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2234
@jtopjian this is already ready for review. If it is fine, I'd like to merge it ASAP. Thanks in advance.