Skip to content

Swift V1: fix setting empty headers#2218

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:swift-headers
Sep 20, 2021
Merged

Swift V1: fix setting empty headers#2218
jtopjian merged 1 commit intogophercloud:masterfrom
kayrus:swift-headers

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Sep 17, 2021

resolves #2215
cc @jtopjian

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.821% when pulling 29e0cb3 on kayrus:swift-headers into 9cf6777 on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

@kayrus Nice - thank you! I want to run the acceptance tests on a couple of clouds. Give me a few days to get around to that.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Sep 17, 2021

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

@kayrus This looks good to me. Let me know when you're ready for this to be merged.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Sep 20, 2021

@jtopjian it is ready. thank you.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swift V1: Cannot delete ACL rules

3 participants