add tag attribute to servers.Network#2193
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jul 15, 2021
Merged
Conversation
|
Build failed.
|
Contributor
|
recheck |
|
Build failed.
|
Contributor
|
Interesting. The same failure as last time. Other PRs are passing, though. I'm going to try one more time. |
Contributor
|
recheck |
|
Build failed.
|
Contributor
|
Different test failure, but it was with submitting the test results. Everything looks like it passed. @majewsky This looks good to me. Let me know if you are ready for this to be merged. |
Contributor
Author
|
Yes, please, by all means. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2192.
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: Links are given in the issue.
I was going to extend the tests to handle this attribute, but there are no tests at all that actually cover the
networksattribute of server creation requests, so I hope this change is okay as-is.