Compute v2: Add the user id to the get create and delete keypair#2186
Merged
jtopjian merged 7 commits intogophercloud:masterfrom Jul 2, 2021
Merged
Compute v2: Add the user id to the get create and delete keypair#2186jtopjian merged 7 commits intogophercloud:masterfrom
jtopjian merged 7 commits intogophercloud:masterfrom
Conversation
Contributor
Author
|
@kayrus Let me know your thoughts on this. Generally, I'm not opposed to adding an |
|
Build succeeded.
|
kayrus
reviewed
Jul 1, 2021
| // GetWithOpts is similar to Get, but can take a GetOpts struct. | ||
| // The options within GetOpts require the client to have a microversion set. | ||
| // The original Get function is retained for non-microverisoned requests. | ||
| func GetWithOpts(client *gophercloud.ServiceClient, name string, opts GetOptsBuilder) (r GetResult) { |
Contributor
There was a problem hiding this comment.
@jtopjian GetWithOpts func looks hacky. I'd extend the Get function, even if it breaks the previous API.
Contributor
|
@jtopjian can you also add a |
|
Build failed.
|
Contributor
|
@jtopjian thanks a lot. LGTM. |
This was referenced Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2145
Supersedes #2146