Trove: Support to return Trove instance addresses#2179
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 28, 2021
Merged
Trove: Support to return Trove instance addresses#2179jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
|
Build succeeded.
|
Contributor
|
@lingxiankong This looks good to me. Let me know when you're ready to have it merged. |
Contributor
Author
|
@jtopjian I've no idea why the job |
- API response example for getting trove instance : https://docs.openstack.org/api-ref/database/?expanded=show-database-instance-details-detail#id52 - Trove code for getting instance addresses: https://github.com/openstack/trove/blob/b050996b9f6df738a0f68ac36a5b5f17f8bb2bc2/trove/instance/models.py#L170 Closes: gophercloud#2178
149c005 to
321b02c
Compare
Contributor
Author
Never mind, found the problem |
|
Build succeeded.
|
Contributor
Author
|
@jtopjian Ready |
Contributor
|
@lingxiankong Good catch. I totally spaced on the unit test error :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2178
https://docs.openstack.org/api-ref/database/?expanded=show-database-instance-details-detail#id52
https://github.com/openstack/trove/blob/b050996b9f6df738a0f68ac36a5b5f17f8bb2bc2/trove/instance/models.py#L170