Skip to content

blockstorage/v3: Add support for list qos#2167

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
nikParasyr:qos_list
Jun 17, 2021
Merged

blockstorage/v3: Add support for list qos#2167
jtopjian merged 1 commit intogophercloud:masterfrom
nikParasyr:qos_list

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

@nikParasyr nikParasyr commented May 20, 2021

@coveralls
Copy link
Copy Markdown

coveralls commented May 20, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 79.902% when pulling 7071555 on nikParasyr:qos_list into b99817b on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented May 20, 2021

Build failed.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented May 20, 2021

@nikParasyr Thanks! I'm working on getting OpenLab fixed

jtopjian
jtopjian reviewed May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikParasyr Thanks! I've left one non-blocking comment.

If you can confirm that the acceptance tests pass, I can merge this while we're waiting for the OpenLab test issues to resolve.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

nikParasyr commented May 27, 2021

@jtopjian I cannot see the non-blocking comment 🤔

If you can confirm that the acceptance tests pass, I can merge this while we're waiting for the OpenLab test issues to resolve

From my side it's ok to wait for the fix. I'll be off for the coming 10 days for vacation and other things. When i get back if OpenLab is not fixed yet ill make a devstack environment and provide the output.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 14, 2021

Build failed.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

nikParasyr commented Jun 14, 2021

@jtopjian Ive rebased with all the latest and greatest from master but openlab still fails. It seems a bit unrelated with my addition.
I ran the tests on a train cluster. Results:
Acceptane:

gophercloudtest TestQoS blockstorage/v3                                                                                                                                                                                                                                                                                  7.16G   100% 🔋  10087  17:16:01  
~/go/src/github.com/gophercloud/gophercloud ~
=== RUN   TestQoS
    TestQoS: blockstorage.go:281: Attempting to create QoS: ACPTTESTPjXBbX0wT5Il0628
    TestQoS: tools.go:80: {
          "name": "ACPTTESTPjXBbX0wT5Il0628",
          "id": "9d3a1f49-b855-4bea-91a1-80db6008f7c2",
          "consumer": "front-end",
          "specs": {
            "read_iops_sec": "20000"
          }
        }
    TestQoS: blockstorage.go:301: Successfully created QoS: 9d3a1f49-b855-4bea-91a1-80db6008f7c2
    TestQoS: blockstorage.go:281: Attempting to create QoS: ACPTTESTpLcdJVmlgMPKtw5U
    TestQoS: tools.go:80: {
          "name": "ACPTTESTpLcdJVmlgMPKtw5U",
          "id": "083b77a8-a383-4061-86d4-241455e07766",
          "consumer": "front-end",
          "specs": {
            "read_iops_sec": "20000"
          }
        }
    TestQoS: blockstorage.go:301: Successfully created QoS: 083b77a8-a383-4061-86d4-241455e07766
    TestQoS: blockstorage.go:309: Attempting to delete QoS: 083b77a8-a383-4061-86d4-241455e07766
    TestQoS: blockstorage.go:320: Successfully deleted QoS: 083b77a8-a383-4061-86d4-241455e07766
    TestQoS: blockstorage.go:309: Attempting to delete QoS: 9d3a1f49-b855-4bea-91a1-80db6008f7c2
    TestQoS: blockstorage.go:320: Successfully deleted QoS: 9d3a1f49-b855-4bea-91a1-80db6008f7c2
--- PASS: TestQoS (0.96s)
PASS
ok  	github.com/gophercloud/gophercloud/acceptance/openstack/blockstorage/v3	0.962s

Unit:

go test -v -tags fixtures ./...                                                                                                                                                                                                                                                                                                               7.12G   100% 🔋  10092  17:22:08  
?   	github.com/gophercloud/gophercloud/openstack/blockstorage/v3/qos	[no test files]
=== RUN   TestCreate
--- PASS: TestCreate (0.00s)
=== RUN   TestDelete
--- PASS: TestDelete (0.00s)
=== RUN   TestList
--- PASS: TestList (0.00s)
PASS
ok  	github.com/gophercloud/gophercloud/openstack/blockstorage/v3/qos/testing	0.005s

jtopjian
jtopjian approved these changes Jun 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 1fdbee5 into gophercloud:master Jun 17, 2021
@nikParasyr nikParasyr deleted the qos_list branch June 17, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikParasyr @coveralls @jtopjian