Coverage increased (+0.009%) to 79.867% when pulling 2ca6529 on nikParasyr:blockstorage_v3_qos into 5137346 on gophercloud:master.

Build succeeded.

• gophercloud-unittest : SUCCESS in 3m 54s
• gophercloud-acceptance-test : SUCCESS in 1h 53m 04s
• gophercloud-acceptance-test-ironic : SUCCESS in 27m 40s

@jtopjian this is ready from my side.

@nikParasyr Thanks!

This set of API calls is a bit strange. The schema only defines a single field called name and then allows any other arbitrary field to be specified. I'm sure this is because of the many variations of QoS parameters that are possible. However, in theory, foobar is also a valid field.

With that in mind, from reading the other Python code, I do agree with your assessment for using Name, Consumer, and Specs as fields. I also agree with how the Specs are modified to be inline with the top-level of the request body.

One optional change you can make is to define the different types of consumers as types, since there is only a finite set of acceptable values for consumer: https://github.com/openstack/cinder/blob/acfc148d7cec08362873115abb4551d2ba531d06/cinder/objects/fields.py#L139-L142

You can see an example of this here:

• https://github.com/gophercloud/gophercloud/blob/master/openstack/networking/v2/extensions/security/rules/requests.go#L50-L77
• https://github.com/gophercloud/gophercloud/blob/master/openstack/networking/v2/extensions/security/rules/requests.go#L90

Note that this type would only be used in the functions in requests.go. For the resulting struct in results.go, the field would still be a string.

Again, this is optional, but encouraged as it helps model the data more accurately.

Please let me know if you have any questions.

Build failed.

• gophercloud-unittest : SUCCESS in 4m 31s
• gophercloud-acceptance-test : FAILURE in 1h 13m 45s
• gophercloud-acceptance-test-ironic : SUCCESS in 25m 15s

recheck

Build failed.

• gophercloud-unittest : SUCCESS in 4m 19s
• gophercloud-acceptance-test : FAILURE in 17m 48s
• gophercloud-acceptance-test-ironic : SUCCESS in 27m 04s

recheck

Build succeeded.

• gophercloud-unittest : SUCCESS in 4m 13s
• gophercloud-acceptance-test : SUCCESS in 1h 48m 09s
• gophercloud-acceptance-test-ironic : SUCCESS in 51m 21s

@jtopjian thanks for the help :) The changes are done. Let me know if anything is missing